publish cache retained

.woodpecker.yml

@@ -23,7 +23,6 @@ steps:
         exclude:
         - refs/tags/*-configchange
 
-
   namespace:
     image: quay.io/wollud1969/k8s-admin-helper:0.3.4
     environment:
@@ -34,6 +33,10 @@ steps:
       - printf "$KUBE_CONFIG_CONTENT" > /tmp/kubeconfig
       - export KUBECONFIG=/tmp/kubeconfig
       - kubectl create namespace $NAMESPACE || echo "Namespace $NAMESPACE already exists"
+    when:
+      ref:
+        exclude:
+        - refs/tags/*-configchange
 
   configuration:
     image: quay.io/wollud1969/k8s-admin-helper:0.3.4

config/config.yaml

@@ -1,6 +1,6 @@
 global:
-  scan_interval: 1
-  log_level: DEBUG
+  scan_interval: 0.25
+  log_level: INFO
 
 mqtt:
   broker: emqx01-anonymous-cluster-internal.broker.svc.cluster.local
@@ -123,10 +123,11 @@ output:
   - name: pv_control
     publish_topic: IoT/PV/Control/State
     scan_rate: 1
+    raw_output: true # use only for output device with only one register, name this register 'output'
     slave_id: 1
     registers:
       - address: 0x0001
-        attribute: state
+        attribute: output
         name: State
         unit: "-"
         register_type: holding
@@ -136,10 +137,11 @@ output:
     enabled: true
     publish_topic: IoT/Car/Control/State
     scan_rate: 1
+    raw_output: true # use only for output device with only one register, name this register 'output'
     slave_id: 5
     registers:
       - address: 0x0001
-        attribute: state
+        attribute: output
         name: State
         unit: "-"
         register_type: holding
@@ -228,3 +230,17 @@ output:
         register_type: input
         data_type: float32
         adaptor: floatAdaptor
+  - name: car_feedback
+    enabled: true
+    publish_topic: IoT/Car/Feedback/State
+    scan_rate: 1
+    raw_output: true # use only for output device with only one register, name this register 'output'
+    slave_id: 7
+    registers:
+      - address: 0x0010
+        attribute: output
+        name: State
+        unit: "-"
+        register_type: holding
+        data_type: int32
+        adaptor: onOffAdaptor

src/pv_controller/FromDevices.py

@@ -9,7 +9,7 @@ def floatAdaptor(i):
     return float(f"{i:0.2f}") if i else 0.0
 
 def onOffAdaptor(i):
-    return bool(i)
+    return 'on' if bool(i) else 'off'
 
 
 
@@ -49,12 +49,13 @@ class FromDevices(AbstractMqttPublisher):
                         payload[registers.attribute] = value
 
                     payload['status'] = "Ok"
+                    payload['cnt'] = cnt
+                
+                    payloadStr = json.dumps(payload) if not device.raw_output else str(payload['output'])
+                    self.publish_with_cache(device.publish_topic, payloadStr)
+                    logger.debug(f"mqtt message sent: {device.publish_topic} -> {payloadStr}")
                 except Exception as e:
                     logger.error(f"Caught exception: {str(e)}")
 
-                payload['cnt'] = cnt
-                payloadStr = json.dumps(payload)
-                self.client.publish(device.publish_topic, payloadStr)
-                logger.debug(f"mqtt message sent: {device.publish_topic} -> {payloadStr}")
 
             self.killEvent.wait(timeout=float(self.config.global_.scan_interval))

src/pv_controller/MqttBase.py

@@ -25,6 +25,8 @@ class AbstractMqttPublisher(threading.Thread):
         logger.info(f"mqtt client id: {client_id}")
         self.client = mqtt.Client(client_id=client_id, userdata=self)
 
+        self.cache = {}
+
         # consider this flag in the localLoop
         self.killBill = False
         self.killEvent = threading.Event()
@@ -62,3 +64,10 @@ class AbstractMqttPublisher(threading.Thread):
     def onMessage(self, topic, payload):
         logger.warning("mqtt unexpected message received: {} -> {}".format(topic, str(payload)))
 
+    def publish_with_cache(self, topic, payload):
+        if topic in self.cache and self.cache[topic] == payload:
+            logger.debug(f"mqtt message unchanged, not publishing: {topic} -> {payload}")
+            return
+        self.cache[topic] = payload
+        self.client.publish(topic, payload, retain=True)
+

src/pv_controller/ToDevices.py

@@ -24,7 +24,7 @@ class ToDevices(AbstractMqttPublisher):
                     continue
                 if device.register_type != 'coil':
                     raise Exception(f"Unsupported register type {device.register_type} for input device {device.name}")
-                value = payload == b'On'
+                value = payload == b'on'
                 self.modbusHandler.writeCoil(device.slave_id, device.address, value)
         except Exception as e:
             logger.error(f"Caught exception in onMessage: {str(e)}")

src/pv_controller/config.py

@@ -24,6 +24,7 @@ class OutputConfig(BaseModel):
     enabled: bool = Field(default=True)
     scan_rate: Optional[int] = Field(default=60)
     publish_topic: str
+    raw_output: Optional[bool] = Field(default=False)
     slave_id: int
     registers: List[RegisterConfig]
 
@@ -50,7 +51,7 @@ class ModbusConfig(BaseModel):
 
 class GlobalConfig(BaseModel):
     """Global settings"""
-    scan_interval: int
+    scan_interval: float
     log_level: str