From d32eb45bea1e7062777f2f5e9a0caf036a6521dd Mon Sep 17 00:00:00 2001
From: Wolfgang Hottgenroth <wolfgang.hottgenroth@icloud.com>
Date: Thu, 17 Dec 2020 09:02:46 +0100
Subject: [PATCH] addDevice

---
 cube/User/Src/configCmds.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/cube/User/Src/configCmds.c b/cube/User/Src/configCmds.c
index f75402c..efa6902 100644
--- a/cube/User/Src/configCmds.c
+++ b/cube/User/Src/configCmds.c
@@ -164,7 +164,7 @@ static bool makeDevice(uint8_t argOffset, uint8_t argc, char **args, t_deviceBlo
         sendString("address: between 1 and 254\n\r");
         sendString("period: in seconds, between 0 (disabled) and 86400 (1 day)\n\r");
         sendString("fields: between -1 (not considered) and 254\n\r");
-        return true;
+        return false;
     }
     if (strlen(deviceName) >= sizeof(deviceBlock->deviceName)) {
         sendString("devicename too long\n\r");
@@ -201,12 +201,13 @@ static bool makeDevice(uint8_t argOffset, uint8_t argc, char **args, t_deviceBlo
 static bool addDeviceCmd(uint8_t argc, char **args) {
     t_deviceBlock deviceBlock;
     bool retCode = makeDevice(0, argc, args, &deviceBlock);
-
-    sendString("New device would be:\n\r");
-    sendFormatString("  Name: %s, Address: %d, Period: %d\n\r", 
-                     deviceBlock.deviceName, deviceBlock.address, deviceBlock.period);
-    for (uint8_t i = 0; i < MBUSDEVICE_NUM_OF_CONSIDEREDFIELDS; i++) {
-        sendFormatString("  Considered field: %d\n\r", deviceBlock.consideredField[i]);
+    if (retCode) {
+        sendString("New device would be:\n\r");
+        sendFormatString("  Name: %s, Address: %d, Period: %d\n\r", 
+                         deviceBlock.deviceName, deviceBlock.address, deviceBlock.period);
+        for (uint8_t i = 0; i < MBUSDEVICE_NUM_OF_CONSIDEREDFIELDS; i++) {
+            sendFormatString("  Considered field: %d\n\r", deviceBlock.consideredField[i]);
+        }
     }
 
     return retCode;