kugellampe patty

apps/abstraction/main.py

@@ -181,17 +181,9 @@ async def handle_abstract_set(
     # Transform abstract payload to vendor-specific format
     vendor_payload = transform_abstract_to_vendor(device_type, device_technology, abstract_payload)
         
-    # For MAX! thermostats and Shelly relays, vendor_payload is a plain string
-    # For other devices, it's a dict that needs JSON encoding
-    if (device_technology == "max" and device_type == "thermostat") or \
-       (device_technology == "shelly" and device_type == "relay"):
-        vendor_message = vendor_payload  # Already a string
-    else:
-        vendor_message = json.dumps(vendor_payload)
-    
-    logger.info(f"→ vendor SET {device_id}: {vendor_topic} ← {vendor_message}")
-    logger.debug(f"MQTT message published on {vendor_topic}: {vendor_message}")
-    await mqtt_client.publish(vendor_topic, vendor_message, qos=1)
+    logger.info(f"→ vendor SET {device_id}: {vendor_topic} ← {vendor_payload}")
+    logger.debug(f"MQTT message published on {vendor_topic}: {vendor_payload}")
+    await mqtt_client.publish(vendor_topic, vendor_payload, qos=1)
 
 
 async def handle_vendor_state(

apps/abstraction/transformation.py

@@ -17,12 +17,12 @@ logger = logging.getLogger(__name__)
 # HANDLER FUNCTIONS: simulator technology
 # ============================================================================
 
-def _transform_light_simulator_to_vendor(payload: dict[str, Any]) -> dict[str, Any]:
+def _transform_light_simulator_to_vendor(payload: dict[str, Any]) -> str:
     """Transform abstract light payload to simulator format.
     
     Simulator uses same format as abstract protocol (no transformation needed).
     """
-    return payload
+    return json.dumps(payload)
 
 
 def _transform_light_simulator_to_abstract(payload: str) -> dict[str, Any]:
@@ -36,12 +36,12 @@ def _transform_light_simulator_to_abstract(payload: str) -> dict[str, Any]:
     return payload
 
 
-def _transform_thermostat_simulator_to_vendor(payload: dict[str, Any]) -> dict[str, Any]:
+def _transform_thermostat_simulator_to_vendor(payload: dict[str, Any]) -> str:
     """Transform abstract thermostat payload to simulator format.
     
     Simulator uses same format as abstract protocol (no transformation needed).
     """
-    return payload
+    return json.dumps(payload)
 
 
 def _transform_thermostat_simulator_to_abstract(payload: str) -> dict[str, Any]:
@@ -59,7 +59,7 @@ def _transform_thermostat_simulator_to_abstract(payload: str) -> dict[str, Any]:
 # HANDLER FUNCTIONS: zigbee2mqtt technology
 # ============================================================================
 
-def _transform_light_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> dict[str, Any]:
+def _transform_light_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> str:
     """Transform abstract light payload to zigbee2mqtt format.
     
     Transformations:
@@ -84,7 +84,7 @@ def _transform_light_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> dict[str,
             # Convert percentage (0-100) to zigbee2mqtt range (0-254)
             vendor_payload["brightness"] = round(abstract_brightness * 254 / 100)
     
-    return vendor_payload
+    return json.dumps(vendor_payload)
 
 
 def _transform_light_zigbee2mqtt_to_abstract(payload: str) -> dict[str, Any]:
@@ -115,7 +115,7 @@ def _transform_light_zigbee2mqtt_to_abstract(payload: str) -> dict[str, Any]:
     return abstract_payload
 
 
-def _transform_thermostat_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> dict[str, Any]:
+def _transform_thermostat_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> str:
     """Transform abstract thermostat payload to zigbee2mqtt format.
     
     Transformations:
@@ -132,7 +132,7 @@ def _transform_thermostat_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> dict
         # zigbee2mqtt expects current_heating_setpoint as string
         vendor_payload["current_heating_setpoint"] = str(payload["target"])
     
-    return vendor_payload
+    return json.dumps(vendor_payload)
 
 
 def _transform_thermostat_zigbee2mqtt_to_abstract(payload: str) -> dict[str, Any]:
@@ -171,14 +171,14 @@ def _transform_thermostat_zigbee2mqtt_to_abstract(payload: str) -> dict[str, Any
 # HANDLER FUNCTIONS: contact_sensor - zigbee2mqtt technology
 # ============================================================================
 
-def _transform_contact_sensor_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> dict[str, Any]:
+def _transform_contact_sensor_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> str:
     """Transform abstract contact sensor payload to zigbee2mqtt format.
     
     Contact sensors are read-only, so this should not be called for SET commands.
     Returns payload as-is for compatibility.
     """
     logger.warning("Contact sensors are read-only - SET commands should not be used")
-    return payload
+    return json.dumps(payload)
 
 
 def _transform_contact_sensor_zigbee2mqtt_to_abstract(payload: str) -> dict[str, Any]:
@@ -225,14 +225,14 @@ def _transform_contact_sensor_zigbee2mqtt_to_abstract(payload: str) -> dict[str,
 # HANDLER FUNCTIONS: contact_sensor - max technology (Homegear MAX!)
 # ============================================================================
 
-def _transform_contact_sensor_max_to_vendor(payload: dict[str, Any]) -> dict[str, Any]:
+def _transform_contact_sensor_max_to_vendor(payload: dict[str, Any]) -> str:
     """Transform abstract contact sensor payload to MAX! format.
     
     Contact sensors are read-only, so this should not be called for SET commands.
     Returns payload as-is for compatibility.
     """
     logger.warning("Contact sensors are read-only - SET commands should not be used")
-    return payload
+    return json.dumps(payload)
 
 
 def _transform_contact_sensor_max_to_abstract(payload: str) -> dict[str, Any]:
@@ -266,13 +266,13 @@ def _transform_contact_sensor_max_to_abstract(payload: str) -> dict[str, Any]:
 # HANDLER FUNCTIONS: temp_humidity_sensor - zigbee2mqtt technology
 # ============================================================================
 
-def _transform_temp_humidity_sensor_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> dict[str, Any]:
+def _transform_temp_humidity_sensor_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> str:
     """Transform abstract temp/humidity sensor payload to zigbee2mqtt format.
     
     Temp/humidity sensors are read-only, so this should not be called for SET commands.
     Returns payload as-is for compatibility.
     """
-    return payload
+    return json.dumps(payload)
 
 
 def _transform_temp_humidity_sensor_zigbee2mqtt_to_abstract(payload: str) -> dict[str, Any]:
@@ -284,36 +284,13 @@ def _transform_temp_humidity_sensor_zigbee2mqtt_to_abstract(payload: str) -> dic
     return payload
 
 
-# ============================================================================
-# HANDLER FUNCTIONS: temp_humidity_sensor - MAX! technology
-# ============================================================================
-
-def _transform_temp_humidity_sensor_max_to_vendor(payload: str) -> dict[str, Any]:
-    """Transform abstract temp/humidity sensor payload to MAX! format.
-    
-    Temp/humidity sensors are read-only, so this should not be called for SET commands.
-    Returns payload as-is for compatibility.
-    """
-
-    payload = json.loads(payload)
-
-    return payload
-
-
-def _transform_temp_humidity_sensor_max_to_abstract(payload: str) -> dict[str, Any]:
-    """Transform MAX! temp/humidity sensor payload to abstract format.
-    
-    Passthrough - MAX! provides temperature, humidity, battery directly.
-    """
-    payload = json.loads(payload)
-    return payload
 
 
 # ============================================================================
 # HANDLER FUNCTIONS: relay - zigbee2mqtt technology
 # ============================================================================
 
-def _transform_relay_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> dict[str, Any]:
+def _transform_relay_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> str:
     """Transform abstract relay payload to zigbee2mqtt format.
     
     Relay only has power on/off, same transformation as light.
@@ -325,7 +302,7 @@ def _transform_relay_zigbee2mqtt_to_vendor(payload: dict[str, Any]) -> dict[str,
         power_value = vendor_payload.pop("power")
         vendor_payload["state"] = power_value.upper() if isinstance(power_value, str) else power_value
     
-    return vendor_payload
+    return json.dumps(vendor_payload)
 
 
 def _transform_relay_zigbee2mqtt_to_abstract(payload: str) -> dict[str, Any]:
@@ -416,7 +393,7 @@ def _transform_relay_hottis_pv_modbus_to_abstract(payload: str) -> dict[str, Any
 # HANDLER FUNCTIONS: three_phase_powermeter - hottis_pv_modbus technology
 # ============================================================================
 
-def _transform_three_phase_powermeter_hottis_pv_modbus_to_vendor(payload: dict[str, Any]) -> dict[str, Any]:
+def _transform_three_phase_powermeter_hottis_pv_modbus_to_vendor(payload: dict[str, Any]) -> str:
     """Transform abstract three_phase_powermeter payload to hottis_pv_modbus format.
     energy: float = Field(..., description="Total energy in kWh")
     total_power: float = Field(..., description="Total power in W")
@@ -447,32 +424,53 @@ def _transform_three_phase_powermeter_hottis_pv_modbus_to_vendor(payload: dict[s
         "phase3_current": payload.get("phase3_current", 0.0),
     }
 
-    return vendor_payload
+    return json.dumps(vendor_payload)
 
 
 def _transform_three_phase_powermeter_hottis_pv_modbus_to_abstract(payload: str) -> dict[str, Any]:
     """Transform hottis_pv_modbus three_phase_powermeter payload to abstract format.
     
     Transformations:
-    - Direct mapping of all power meter fields
-    
-    Example:
-    - hottis_pv_modbus: {'energy': 123.45, 'total_power': 1500.0, 'phase1_power': 500.0, ...}
-    - Abstract: {'energy': 123.45, 'total_power': 1500.0, 'phase1_power': 500.0, ...}
+    - Map vendor field names to abstract field names
+        - totalImportEnergy        -> energy
+        - powerL1/powerL2/powerL3  -> phase1_power/phase2_power/phase3_power
+        - voltageL1/voltageL2/voltageL3 -> phase1_voltage/phase2_voltage/phase3_voltage
+        - currentL1/currentL2/currentL3 -> phase1_current/phase2_current/phase3_current
+        - Sum of powerL1..3        -> total_power
     """
-    payload = json.loads(payload)
+    data = json.loads(payload)
+
+    # Helper to read numeric values uniformly as float
+    def _get_float(key: str, default: float = 0.0) -> float:
+        return float(data.get(key, default))
+
+    # Read all numeric values via helper for consistent error handling
+    phase1_power = _get_float("powerL1")
+    phase2_power = _get_float("powerL2")
+    phase3_power = _get_float("powerL3")
+
+    phase1_voltage = _get_float("voltageL1")
+    phase2_voltage = _get_float("voltageL2")
+    phase3_voltage = _get_float("voltageL3")
+
+    phase1_current = _get_float("currentL1")
+    phase2_current = _get_float("currentL2")
+    phase3_current = _get_float("currentL3")
+
+    energy = _get_float("totalImportEnergy")
+
     abstract_payload = {
-        "energy": payload.get("energy", 0.0),
-        "total_power": payload.get("total_power", 0.0),
-        "phase1_power": payload.get("phase1_power", 0.0),
-        "phase2_power": payload.get("phase2_power", 0.0),
-        "phase3_power": payload.get("phase3_power", 0.0),
-        "phase1_voltage": payload.get("phase1_voltage", 0.0),
-        "phase2_voltage": payload.get("phase2_voltage", 0.0),
-        "phase3_voltage": payload.get("phase3_voltage", 0.0),
-        "phase1_current": payload.get("phase1_current", 0.0),
-        "phase2_current": payload.get("phase2_current", 0.0),
-        "phase3_current": payload.get("phase3_current", 0.0),
+        "energy": energy,
+        "total_power": phase1_power + phase2_power + phase3_power,
+        "phase1_power": phase1_power,
+        "phase2_power": phase2_power,
+        "phase3_power": phase3_power,
+        "phase1_voltage": phase1_voltage,
+        "phase2_voltage": phase2_voltage,
+        "phase3_voltage": phase3_voltage,
+        "phase1_current": phase1_current,
+        "phase2_current": phase2_current,
+        "phase3_current": phase3_current,
     }
 
     return abstract_payload
@@ -573,12 +571,8 @@ TRANSFORM_HANDLERS: dict[tuple[str, str, str], TransformHandler] = {
     # Temperature & humidity sensor transformations (support both type aliases)
     ("temp_humidity_sensor", "zigbee2mqtt", "to_vendor"): _transform_temp_humidity_sensor_zigbee2mqtt_to_vendor,
     ("temp_humidity_sensor", "zigbee2mqtt", "to_abstract"): _transform_temp_humidity_sensor_zigbee2mqtt_to_abstract,
-    ("temp_humidity_sensor", "max", "to_vendor"): _transform_temp_humidity_sensor_max_to_vendor,
-    ("temp_humidity_sensor", "max", "to_abstract"): _transform_temp_humidity_sensor_max_to_abstract,
     ("temp_humidity", "zigbee2mqtt", "to_vendor"): _transform_temp_humidity_sensor_zigbee2mqtt_to_vendor,
     ("temp_humidity", "zigbee2mqtt", "to_abstract"): _transform_temp_humidity_sensor_zigbee2mqtt_to_abstract,
-    ("temp_humidity", "max", "to_vendor"): _transform_temp_humidity_sensor_max_to_vendor,
-    ("temp_humidity", "max", "to_abstract"): _transform_temp_humidity_sensor_max_to_abstract,
     
     # Relay transformations
     ("relay", "zigbee2mqtt", "to_vendor"): _transform_relay_zigbee2mqtt_to_vendor,

config/devices.yaml

@@ -783,6 +783,17 @@ devices:
   topics:
     set: "shellies/lichtterasse/relay/0/command"
     state: "shellies/lichtterasse/relay/0"
+- device_id: kugellampe_patty
+  name: Kugellampe Patty
+  type: light
+  cap_version: "light@1.2.0"
+  technology: zigbee2mqtt
+  features:
+    power: true
+    brightness: true
+  topics:
+    state: "zigbee2mqtt/0xbc33acfffe21f547"
+    set: "zigbee2mqtt/0xbc33acfffe21f547/set"
 
 - device_id: power_relay_caroutlet
   name: Car Outlet
@@ -799,8 +810,8 @@ devices:
   name: Car Outlet
   type: three_phase_powermeter
   cap_version: "three_phase_powermeter@1.0.0"
-  technology: hottis_modbus
+  technology: hottis_pv_modbus
   topics:
-    state: "caroutlet/powermeter"
+    state: "IoT/Car/Values"
 
 

config/layout.yaml

@@ -165,6 +165,10 @@ rooms:
     title: Schranklicht vorne Patty
     icon: 💡
     rank: 180
+  - device_id: kugellampe_patty
+    title: Kugellampe Patty
+    icon: 💡
+    rank: 181
   - device_id: thermostat_patty
     title: Thermostat Patty
     icon: 🌡️