diff --git a/gitlabreleaseuploader.py b/gitlabreleaseuploader.py index fde4871..c18a8e1 100755 --- a/gitlabreleaseuploader.py +++ b/gitlabreleaseuploader.py @@ -100,23 +100,24 @@ uploadUrl = "%s/api/v4/projects/%s/uploads" % (instanceUrl, projectId) headers = {"PRIVATE-TOKEN": privateToken} assets = [] -for f in filesToUpload: - files = {"file": open(f, 'rb')} +for filename in filesToUpload: + with open(filename, 'rb') as filehandle: + files = {"file": filehandle} - uploadResult = requests.post(uploadUrl, files=files, headers=headers, verify=caBundle) + uploadResult = requests.post(uploadUrl, files=filehandle, headers=headers, verify=caBundle) - if uploadResult.status_code != 201: - print(uploadResult) - print(uploadResult.text) - raise Exception('Unable to upload file to Gitlab') + if uploadResult.status_code != 201: + print(uploadResult) + print(uploadResult.text) + raise Exception('Unable to upload file to Gitlab') - if verbose: - print(uploadResult) - print(uploadResult.text) - print('File {} successfully uploaded'.format(f)) + if verbose: + print(uploadResult) + print(uploadResult.text) + print('File {} successfully uploaded'.format(filename)) - url = projectUrl + json.loads(uploadResult.text)['url'] - assets.append({'name': f, 'url': url}) + url = projectUrl + json.loads(uploadResult.text)['url'] + assets.append({'name': filename, 'url': url}) # --- create release tag if createReleaseTag: