fix

auth.py

@@ -38,6 +38,9 @@ except KeyError:
 class NoUserException(Exception): 
     pass
 
+class RefreshTokenExpiredException(Exception): 
+    pass
+
 class NoTokenException(Exception): 
     pass
 
@@ -145,8 +148,8 @@ def getRefreshTokenFromDB(application, login):
 
             with conn.cursor() as cur:
                 salt = ''.join(random.choice(string.ascii_letters + string.digits) for _ in range(64))
-                cur.execute('INSERT INTO token_t ("user", salt)  VALUES (%s, %s) RETURNING id', 
+                cur.execute('INSERT INTO token_t ("user", salt, expiry)  VALUES (%s, %s, %s) RETURNING id', 
-                            (userObj[0], salt))
+                            (userObj[0], salt, userObj[1]))
                 tokenObj = cur.fetchone()
                 logger.debug("tokenObj: {}".format(tokenObj))
                 if not tokenObj:
@@ -297,19 +300,18 @@ def checkAndInvalidateRefreshToken(login, xid, xal):
                             '  WHERE t.id = %s AND ' +
                             '        t.salt = %s AND ' +
                             '        t."user" = u.id AND ' +
-                            '        u.login = %s AND ' +
+                            '        u.login = %s',
-                            '        t.valid = true',
                             (xid, xal, login))
                 tokenObj = cur.fetchone()
                 logger.debug("tokenObj: {}".format(tokenObj))
                 if not tokenObj:
-                    raise NoValidTokenException()
+                    raise NoTokenException()
                 invObj = cur.fetchone()
                 if invObj:
                     raise ManyTokensException()
 
             with conn.cursor() as cur:
-                cur.execute('UPDATE token_t SET valid = false WHERE id = %s', 
+                cur.execute('UPDATE token_t SET used = used + 1 WHERE id = %s', 
                             [ xid ])
     except psycopg2.Error as err:
         raise Exception("Error when connecting to database: {}".format(err))
@@ -324,6 +326,9 @@ def refreshTokens(**args):
         refreshTokenObj = jwt.decode(refreshToken, JWT_PUB_KEY)
         logger.info(str(refreshTokenObj))
 
+        if refreshTokenObj["exp"] < int(time.time()):
+            raise RefreshTokenExpiredException()
+
         checkAndInvalidateRefreshToken(refreshTokenObj["sub"], refreshTokenObj["xid"], refreshTokenObj["xal"])
 
         authToken = _makeSimpleToken(refreshTokenObj["xap"], refreshTokenObj["sub"], "", refresh=True)
@@ -335,8 +340,11 @@ def refreshTokens(**args):
     except JWTError as e:
         logger.error("jwt.decode failed: {}".format(e))
         raise werkzeug.exceptions.Unauthorized()
+    except RefreshTokenExpiredException:
+        logger.error("refresh token expired")
+        raise werkzeug.exceptions.Unauthorized()
     except NoTokenException:
-        logger.error("no token created")
+        logger.error("no token created/found")
         raise werkzeug.exceptions.Unauthorized()
     except NoValidTokenException:
         logger.error("no valid token found")
@@ -356,8 +364,8 @@ def refreshTokens(**args):
     except KeyError:
         logger.error("application, login or password missing")
         raise werkzeug.exceptions.Unauthorized()
-    #except Exception as e:
+    except Exception as e:
-    #    logger.error("unspecific exception: {}".format(str(e)))
+        logger.error("unspecific exception: {}".format(str(e)))
-    #    raise werkzeug.exceptions.Unauthorized()
+        raise werkzeug.exceptions.Unauthorized()