From 015309f20f10653a5947f0648d1a9e73ace9b8c0 Mon Sep 17 00:00:00 2001
From: Wolfgang Hottgenroth <wolfgang.hottgenroth@icloud.com>
Date: Fri, 23 Dec 2022 10:45:09 +0100
Subject: [PATCH] looks good

---
 sketch/configuration.cpp                | 63 ++++++-------------------
 snippets/form_table_config_approach.txt | 36 ++++++++++++++
 2 files changed, 51 insertions(+), 48 deletions(-)
 create mode 100644 snippets/form_table_config_approach.txt

diff --git a/sketch/configuration.cpp b/sketch/configuration.cpp
index f26f2d9..b4a79fc 100644
--- a/sketch/configuration.cpp
+++ b/sketch/configuration.cpp
@@ -111,47 +111,20 @@ static void handleRoot() {
         configParsingFailed = 0;
         buffer << "<h2>Error when parsing field " << configParsingFailed << ", error " << configParsingError << "</h2>";
     }  
-    buffer << "    <form action=\"config\" method=\"GET\">"
+    buffer << "    <form action=\"config\" method=\"POST\">"
               "    <table>"
               "      <tr>"
-              "        <td>"
-              "          DevEui"
-              "        </td><td>";
-    buffer << "          <input type=\"text\" readonly name=\"DevEui\" id=\"DevEui\" size=\"23\" value=\"";    
-    for (int i = 0; i < 8; i++) {
-        if (i != 0) {
-            buffer << ":";
-        }
-        buffer << std::uppercase << std::setfill('0') << std::setw(2) << std::hex << (int)devEui[i];
-    }
-    buffer << "\"> (readonly)";
-    buffer << "        </td>"
-              "      </tr><tr>"
-              "        <td>"
-              "          AppEui"
-              "        </td><td>";
-    buffer << "          <input type=\"text\" name=\"AppEui\" id=\"AppEui\" size=\"23\" value=\"";    
-    for (int i = 0; i < 8; i++) {
-        if (i != 0) {
-            buffer << ":";
-        }
-        buffer << std::uppercase << std::setfill('0') << std::setw(2) << std::hex << (int)myConfig.appEui[i];
-    }
-    buffer << "\">";
-    buffer << "        </td>"
-              "      </tr><tr>"
-              "        <td>"
-              "          AppKey"
-              "        </td><td>";
-    buffer << "          <input type=\"text\" name=\"AppKey\" id=\"AppKey\" size=\"47\" value=\"";    
-    for (int i = 0; i < 16; i++) {
-        if (i != 0) {
-            buffer << ":";
-        }
-        buffer << std::uppercase << std::setfill('0') << std::setw(2) << std::hex << (int)myConfig.appKey[i];
-    }
-    buffer << "\">";
-    buffer << "        </td>"
+              "        <td>";
+    buffer << "          <textarea name=\"config\" cols=\"50\" rows=\"40\">";
+
+    buffer << "# Configuration of the Modbus LoRaWAN Gateway";
+
+    buffer << "          </textarea";
+    buffer << "        </td><td valign=\"top\">"
+              "          Edit the textarea beside. <br/>"
+              "          Make sure to keep all parameters within and follow the shown format.<br/>"
+              "          You can use the # char to introduce line-based comments.<br/>"
+              "        </td>"
               "      </tr>"
               "      <tr><td colspan=\"2\">"
               "        <button type=\"submit\">Save</button>"
@@ -194,17 +167,11 @@ static void parseField(char* arg, int fieldNum, int reqTokens, uint8_t *dest) {
 }
 
 static void handleConfigSave() {
-    char *arg1 = (char*)server.arg("AppEui").c_str();
-    Serial.printf("AppEui: %s\n\r", arg1);
-    parseField(arg1, 1, 8, myConfig.appEui);
+    char *configText = (char*)server.arg("config").c_str();
+    Serial.println(configText);
 
-    if (!configParsingFailed) {
-        char *arg2 = (char*)server.arg("AppKey").c_str();
-        Serial.printf("AppKey: %s\n\r", arg2);
-        parseField(arg2, 2, 16, myConfig.appKey);
-    }
 
-    configSaved = !configParsingFailed;
+    configSaved = true;
     server.sendHeader("Location", String("/"), true);
     server.send(302, "text/plain", "");
 }
diff --git a/snippets/form_table_config_approach.txt b/snippets/form_table_config_approach.txt
new file mode 100644
index 0000000..c29b910
--- /dev/null
+++ b/snippets/form_table_config_approach.txt
@@ -0,0 +1,36 @@
+              "          DevEui"
+              "        </td><td>";
+    buffer << "          <input type=\"text\" readonly name=\"DevEui\" id=\"DevEui\" size=\"23\" value=\"";    
+    for (int i = 0; i < 8; i++) {
+        if (i != 0) {
+            buffer << ":";
+        }
+        buffer << std::uppercase << std::setfill('0') << std::setw(2) << std::hex << (int)devEui[i];
+    }
+    buffer << "\"> (readonly)";
+    buffer << "        </td>"
+              "      </tr><tr>"
+              "        <td>"
+              "          AppEui"
+              "        </td><td>";
+    buffer << "          <input type=\"text\" name=\"AppEui\" id=\"AppEui\" size=\"23\" value=\"";    
+    for (int i = 0; i < 8; i++) {
+        if (i != 0) {
+            buffer << ":";
+        }
+        buffer << std::uppercase << std::setfill('0') << std::setw(2) << std::hex << (int)myConfig.appEui[i];
+    }
+    buffer << "\">";
+    buffer << "        </td>"
+              "      </tr><tr>"
+              "        <td>"
+              "          AppKey"
+              "        </td><td>";
+    buffer << "          <input type=\"text\" name=\"AppKey\" id=\"AppKey\" size=\"47\" value=\"";    
+    for (int i = 0; i < 16; i++) {
+        if (i != 0) {
+            buffer << ":";
+        }
+        buffer << std::uppercase << std::setfill('0') << std::setw(2) << std::hex << (int)myConfig.appKey[i];
+    }
+    buffer << "\">";